Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): Converted card component to typescript #1885

Merged
merged 15 commits into from May 20, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Apr 29, 2019

Fixes #1884

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 29, 2019

@jessiehuff jessiehuff changed the title Converted card component to typescript feat(card): Converted card component to typescript Apr 29, 2019
…e given the context
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #1885 into master will decrease coverage by <.01%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   81.85%   81.84%   -0.01%     
==========================================
  Files         628      628              
  Lines        7159     7178      +19     
  Branches      250      265      +15     
==========================================
+ Hits         5860     5875      +15     
  Misses       1164     1164              
- Partials      135      139       +4
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.88% <90.69%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Card/CardHeader.tsx 88.88% <88.88%> (ø)
...ly-4/react-core/src/components/Card/CardFooter.tsx 90% <90%> (ø)
...nfly-4/react-core/src/components/Card/CardBody.tsx 91.66% <91.66%> (ø)
...tternfly-4/react-core/src/components/Card/Card.tsx 91.66% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e7cb5...2c93464. Read the comment docs.

Copy link
Contributor

redallen left a comment

Hooray~!

@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@jessiehuff can you also add integration tests for this component as outlined on this README?

@redallen redallen added the TypeScript label May 9, 2019
Jessie
@jessiehuff jessiehuff dismissed stale reviews from rebeccaalpert and redallen via cab8547 May 9, 2019
Jessie added 2 commits May 13, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/cardTS branch from 7985564 to 81525b6 May 13, 2019
Jessie
Jessie
Jessie
@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
Copy link
Contributor

tlabaj left a comment

A couple of updates needed based on yesterday's discussion.

Jessie added 2 commits May 17, 2019
Jessie
Jessie
@dlabaj dlabaj self-assigned this May 17, 2019
Copy link
Contributor

tlabaj left a comment

Can you just update the comments to use sentence case. Thanks

Jessie added 3 commits May 20, 2019
Jessie
Jessie
Copy link
Contributor

redallen left a comment

LGTM! 📇

@dlabaj
dlabaj approved these changes May 20, 2019
@tlabaj
tlabaj approved these changes May 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit e3e4170 into patternfly:master May 20, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.