Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example styles for charts and alert #1889

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@dgutride
Copy link
Member

dgutride commented Apr 30, 2019

Also fixes the code example for the docs site
addresses some of: #1724

@dgutride dgutride requested a review from redallen Apr 30, 2019
@dgutride dgutride force-pushed the dgutride:add-styles-back branch from 901c9e7 to e04dcf0 Apr 30, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736f9a8...e04dcf0. Read the comment docs.

}

.chart-title {
margin-bottom: 25px;

This comment has been minimized.

Copy link
@dlabaj

dlabaj Apr 30, 2019

Contributor

Should we be using SASS variables for things that are common in overflow, title, container, margin, etc?

This comment has been minimized.

Copy link
@dgutride

dgutride Apr 30, 2019

Author Member

this was just ported from previous examples and deleted, we can refactor later if you'd like

This comment has been minimized.

Copy link
@dlabaj

dlabaj Apr 30, 2019

Contributor

Okay we can do it later thought this was something new. Thanks.

@dlabaj
dlabaj approved these changes Apr 30, 2019
@redallen redallen merged commit c6fec71 into patternfly:master Apr 30, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redallen redallen mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.