Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Label): Convert Label to TypeScript #1896

Merged
merged 2 commits into from May 9, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Apr 30, 2019

Fixes #1893.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 30, 2019

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from 05394df to 8bc2a5c Apr 30, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #1896 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1896      +/-   ##
=========================================
+ Coverage   82.59%   82.6%   +0.01%     
=========================================
  Files         624     624              
  Lines        6876    6882       +6     
  Branches       93      96       +3     
=========================================
+ Hits         5679    5685       +6     
  Misses       1157    1157              
  Partials       40      40
Flag Coverage Δ
#patternfly3 84.89% <ø> (ø) ⬆️
#patternfly4 79.31% <100%> (+0.04%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Label/Label.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b995b6f...9754735. Read the comment docs.

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from 8bc2a5c to c13ba78 Apr 30, 2019
@rebeccaalpert rebeccaalpert changed the title feat(Convert Label to TypeScript): feat(Label): Convert Label to TypeScript Apr 30, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from c13ba78 to 849c953 May 1, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

1 similar comment
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from 849c953 to 11e77fc May 8, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from 11e77fc to 469bbb1 May 9, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 9, 2019

Added demo and integration tests.

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:label-typescript branch from 469bbb1 to 9754735 May 9, 2019
@kmcfaul
kmcfaul approved these changes May 9, 2019
@redallen redallen added the TypeScript label May 9, 2019
@redallen redallen merged commit a950fd5 into patternfly:master May 9, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:label-typescript branch May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.