Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): Converted button component to typescript #1903

Merged
merged 11 commits into from May 20, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 1, 2019

Fixes issue #1987

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 1, 2019

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/buttonTS branch from 60b52d9 to b39fb12 May 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 1, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@97ea465). Click here to learn what that means.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1903   +/-   ##
=========================================
  Coverage          ?   81.86%           
=========================================
  Files             ?      630           
  Lines             ?     7214           
  Branches          ?      291           
=========================================
  Hits              ?     5906           
  Misses            ?     1164           
  Partials          ?      144
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 77.97% <95.12%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Button/index.ts 100% <100%> (ø)
...nfly-4/react-core/src/components/Button/Button.tsx 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ea465...b63a903. Read the comment docs.

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/buttonTS branch from 1897a80 to 1051e48 May 2, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@jessiehuff can you also add integration tests for this component as outlined on this README?

@redallen redallen added the TypeScript label May 9, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/buttonTS branch from e791b68 to 6b5b0cb May 10, 2019
Copy link
Contributor

tlabaj left a comment

Can you please open an issue for this and add it to the description.

Copy link
Contributor

tlabaj left a comment

Can you also do a git mv of the js to tsx files to retain history.

@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
Copy link
Contributor

tlabaj left a comment

looking good. Another comment about types. This will apply to any other open PRs.

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/buttonTS branch 2 times, most recently from 5b26c0f to 6c140fc May 15, 2019
Copy link
Contributor

tlabaj left a comment

A few more updates needed.

Copy link
Contributor

dlabaj left a comment

Good job a few comments to address.

Jessie
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/buttonTS branch from 4135158 to e5d6b14 May 17, 2019
@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented May 17, 2019

@jessiehuff looks like there's conflicts now.

Jessie
Copy link
Contributor

tlabaj left a comment

@jessiehuff Nice job. This one looks good to go. Can you resolve conflicts so we can get it in.

Jessie
Copy link
Contributor

tlabaj left a comment

Can you rebase to pull in the fix for the broken buil.

Jessie added 4 commits May 17, 2019
Jessie
Jessie
Jessie
Jessie
@dlabaj dlabaj self-assigned this May 17, 2019
Copy link
Contributor

tlabaj left a comment

This one also has the component shape conversion issue.

Jessie added 3 commits May 20, 2019
Jessie
Jessie
Jessie
Copy link
Contributor

redallen left a comment

Thanks for TypeScript s! 👍

onClick={[Function]}
type="button"
variant="plain"
>
<button

This comment has been minimized.

Copy link
@redallen

redallen May 20, 2019

Contributor

These are rendering correctly. That's weird.

Copy link
Contributor

tlabaj left a comment

This one looks good Jessie. Can you just resolve conflicts so we can merge.

Jessie
@jessiehuff jessiehuff dismissed stale reviews from dlabaj and redallen via b63a903 May 20, 2019
@tlabaj
tlabaj approved these changes May 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes May 20, 2019
@dlabaj dlabaj merged commit 2b9d252 into patternfly:master May 20, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.