New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): Convert Text to TypeScript #1907

Merged

dlabaj merged 4 commits into patternfly:master from rebeccaalpert:text-typescript

May 16, 2019

Member

rebeccaalpert commented May 1, 2019

Fixes #1897.

rebeccaalpert added the PF4 label

Contributor

patternfly-build commented May 1, 2019

PatternFly-React preview: https://1907-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 1, 2019 •

edited

Codecov Report

Merging #1907 into master will decrease coverage by 0.06%.
The diff coverage is 83.01%.

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage    82.5%   82.43%   -0.07%     
==========================================
  Files         627      627              
  Lines        6926     6951      +25     
  Branches      108      119      +11     
==========================================
+ Hits         5714     5730      +16     
  Misses       1162     1162              
- Partials       50       59       +9

Flag	Coverage Δ
#patternfly3	`84.88% <ø> (ø)`	⬆️
#patternfly4	`78.93% <83.01%> (-0.13%)`	⬇️
#patternflymisc	`95.68% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
...y-4/react-core/src/components/Text/TextContent.tsx	`80% <66.66%> (ø)`
...-4/react-core/src/components/Text/TextListItem.tsx	`84.61% <84.61%> (ø)`
...nfly-4/react-core/src/components/Text/TextList.tsx	`84.61% <84.61%> (ø)`
...tternfly-4/react-core/src/components/Text/Text.tsx	`85.71% <85.71%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8f20f...6675a5f. Read the comment docs.

tlabaj added the enhancement 🚀 label

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch 2 times, most recently from d6141c7 to e8a3278

Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from e8a3278 to 6bca8ea

Member Author

rebeccaalpert commented May 9, 2019

Added demo and integration test.

redallen added the TypeScript label

Contributor

nicolethoen commented May 9, 2019

LGTM

nicolethoen self-requested a review

nicolethoen reviewed

nicolethoen reviewed

Contributor

nicolethoen left a comment

Well, I guess I should wait to approve until the tests pass...

nicolethoen self-requested a review

rebeccaalpert dismissed nicolethoen’s stale review via d65b48e

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from 6bca8ea to d65b48e


        feat(Text): Convert Text to TypeScript

3b5f0f1

Fixes #1897

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch 4 times, most recently from f7cd3b0 to 6b42986


        test(Text): Add demo and integration test

fe0eb4c

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from 6b42986 to fe0eb4c

redallen requested changes

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextListItem.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextListItem.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextListItem.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

tlabaj added the Do Not Merge label

dlabaj requested changes

Contributor

dlabaj left a comment

A few comments.

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved


        refactor(Text): Address PR feedback

c1aa874

Member Author

rebeccaalpert commented May 13, 2019

Addressed PR feedback.

rachael-phillips mentioned this pull request

Convert Text to typescript #1998

Closed

redallen reviewed

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextContent.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextListItem.tsx Outdated Show resolved Hide resolved

tlabaj added chore 🏠 and removed enhancement 🚀 labels

dlabaj reviewed

dlabaj removed the Do Not Merge label

dlabaj requested a review from redallen

dlabaj added the Do Not Merge label

dlabaj self-requested a review

dlabaj dismissed their stale review

need to rereview

dlabaj requested changes

packages/patternfly-4/react-core/src/components/Text/Text.tsx Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/Text.tsx Outdated Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextList.tsx Show resolved Hide resolved

packages/patternfly-4/react-core/src/components/Text/TextListItem.tsx Show resolved Hide resolved

dlabaj removed the Do Not Merge label

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from e2024cf to c3981c9

Member Author

rebeccaalpert commented May 16, 2019 •

edited

Updated enums/component prop types as discussed.

tlabaj reviewed

Contributor

tlabaj left a comment

LGTM


        refactor(Text): Address PR feedback

6675a5f

rebeccaalpert dismissed tlabaj’s stale review via 6675a5f

rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from c3981c9 to 6675a5f

tlabaj approved these changes

Contributor

tlabaj left a comment

LGTM

dlabaj approved these changes

dlabaj dismissed redallen’s stale review

Updates made based on discussion

dlabaj merged commit ad8e1f5 into patternfly:master

2 checks passed

2 checks passed

ci/circleci: build Your tests passed on CircleCI!

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.