Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): Convert Text to TypeScript #1907

Merged
merged 4 commits into from May 16, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented May 1, 2019

Fixes #1897.

@rebeccaalpert rebeccaalpert added the PF4 label May 1, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 1, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #1907 into master will decrease coverage by 0.06%.
The diff coverage is 83.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage    82.5%   82.43%   -0.07%     
==========================================
  Files         627      627              
  Lines        6926     6951      +25     
  Branches      108      119      +11     
==========================================
+ Hits         5714     5730      +16     
  Misses       1162     1162              
- Partials       50       59       +9
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.93% <83.01%> (-0.13%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-4/react-core/src/components/Text/TextContent.tsx 80% <66.66%> (ø)
...-4/react-core/src/components/Text/TextListItem.tsx 84.61% <84.61%> (ø)
...nfly-4/react-core/src/components/Text/TextList.tsx 84.61% <84.61%> (ø)
...tternfly-4/react-core/src/components/Text/Text.tsx 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8f20f...6675a5f. Read the comment docs.

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch 2 times, most recently from d6141c7 to e8a3278 May 2, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from e8a3278 to 6bca8ea May 9, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 9, 2019

Added demo and integration test.

@redallen redallen added the TypeScript label May 9, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 9, 2019

LGTM

@nicolethoen nicolethoen self-requested a review May 9, 2019
Copy link
Contributor

nicolethoen left a comment

Well, I guess I should wait to approve until the tests pass...

@nicolethoen nicolethoen self-requested a review May 9, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from 6bca8ea to d65b48e May 9, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch 4 times, most recently from f7cd3b0 to 6b42986 May 9, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from 6b42986 to fe0eb4c May 9, 2019
@tlabaj tlabaj added the Do Not Merge label May 10, 2019
Copy link
Contributor

dlabaj left a comment

A few comments.

@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 13, 2019

Addressed PR feedback.

@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
@dlabaj dlabaj removed the Do Not Merge label May 15, 2019
@dlabaj dlabaj requested a review from redallen May 15, 2019
@dlabaj dlabaj added the Do Not Merge label May 15, 2019
@dlabaj dlabaj self-requested a review May 15, 2019
@dlabaj dlabaj dismissed their stale review May 15, 2019

need to rereview

@dlabaj dlabaj removed the Do Not Merge label May 15, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from e2024cf to c3981c9 May 16, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 16, 2019

Updated enums/component prop types as discussed.

Copy link
Contributor

tlabaj left a comment

LGTM

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:text-typescript branch from c3981c9 to 6675a5f May 16, 2019
@tlabaj
tlabaj approved these changes May 16, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes May 16, 2019
@dlabaj dlabaj dismissed redallen’s stale review May 16, 2019

Updates made based on discussion

@dlabaj dlabaj merged commit ad8e1f5 into patternfly:master May 16, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.