Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(brand): Converted brand component to typescript #1918

Merged
merged 3 commits into from May 16, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 2, 2019

Fixes issue #1985

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #1918 into master will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1918      +/-   ##
==========================================
- Coverage   82.43%   82.41%   -0.03%     
==========================================
  Files         627      628       +1     
  Lines        6951     6954       +3     
  Branches      119      121       +2     
==========================================
+ Hits         5730     5731       +1     
  Misses       1162     1162              
- Partials       59       61       +2
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.88% <77.77%> (-0.05%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ternfly-4/react-core/src/components/Brand/index.ts 100% <100%> (ø)
...ernfly-4/react-core/src/components/Brand/Brand.tsx 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64bc3a...3eda914. Read the comment docs.

@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@jessiehuff can you also add integration tests for this component as outlined on this README?

Copy link
Contributor

tlabaj left a comment

Please add integration Test. Also missing prop description.

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented May 8, 2019

@jessiehuff could you also please add the relevant issue to the description. Thanks!

@redallen redallen added the TypeScript label May 9, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/brandTS branch from fb8f79a to 0097dee May 10, 2019
@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
Jessie
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/brandTS branch from 33e07ad to 461c276 May 16, 2019
Jessie added 2 commits May 16, 2019
Jessie
Jessie
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj
tlabaj approved these changes May 16, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes May 16, 2019
@dlabaj dlabaj merged commit 2c52451 into patternfly:master May 16, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.