Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BackgroundImage): fixed background image spacing issue #1923

Merged
merged 12 commits into from May 6, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 3, 2019

Fixes #1922

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 3, 2019

Jessie added 2 commits May 3, 2019
Jessie
Jessie
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@86b7c42). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1923   +/-   ##
=========================================
  Coverage          ?   82.63%           
=========================================
  Files             ?      624           
  Lines             ?     6875           
  Branches          ?       93           
=========================================
  Hits              ?     5681           
  Misses            ?     1154           
  Partials          ?       40
Flag Coverage Δ
#patternfly3 84.89% <ø> (?)
#patternfly4 79.37% <ø> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
.../src/components/BackgroundImage/BackgroundImage.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b7c42...5cdc9c9. Read the comment docs.

@jessiehuff jessiehuff requested review from mcoker and dlabaj May 3, 2019
@mcoker
mcoker approved these changes May 3, 2019
Copy link
Contributor

mcoker left a comment

looks good, thanks!

@tlabaj
tlabaj approved these changes May 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

redallen left a comment

:)

@redallen redallen merged commit ce38bae into patternfly:master May 6, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.