Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add typeahead keyboard navigation #2013

Merged
merged 4 commits into from Jun 5, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented May 15, 2019

What: Adds keyboard interaction to typeahead variants, other variants should remain unchanged.
Enter, with select closed, toggles open the menu.
Focus should remain on input.
Arrow up and down navigates the options with a focus styling.
Enter, with select opened, selects the highlighted item.

Refer to issue: #1842

@kmcfaul kmcfaul added the PF4 label May 15, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 15, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #2013 into master will decrease coverage by 0.6%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   81.09%   80.48%   -0.61%     
==========================================
  Files         643      642       -1     
  Lines        7706     7820     +114     
  Branches      451      509      +58     
==========================================
+ Hits         6249     6294      +45     
- Misses       1257     1286      +29     
- Partials      200      240      +40
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 75.8% <33.33%> (-1.1%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...4/react-core/src/components/Select/SelectToggle.js 48.97% <0%> (-5.57%) ⬇️
...4/react-core/src/components/Select/SelectOption.js 63.63% <100%> (+3.63%) ⬆️
...rnfly-4/react-core/src/components/Select/Select.js 58% <36.84%> (-15.53%) ⬇️
...ckages/patternfly-4/react-core/src/helpers/util.ts 55.71% <7.14%> (-8.7%) ⬇️
...4/react-core/src/components/Select/SingleSelect.js 81.25% <85.71%> (+1.25%) ⬆️
...-4/react-core/src/components/Checkbox/Checkbox.tsx 90.62% <0%> (-2.24%) ⬇️
...omponents/OptionsMenu/OptionsMenuToggleWithText.js
...src/components/OptionsMenu/OptionsMenuItemGroup.js
...src/components/OptionsMenu/OptionsMenuSeparator.js
...core/src/components/OptionsMenu/OptionsMenuItem.js
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c04803...9a9f327. Read the comment docs.

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented May 22, 2019

You have some merge conflicts now, but I like the interaction on the demo!

@kmcfaul kmcfaul force-pushed the kmcfaul:typeahead-keyboard branch from c1b7d08 to 5ba262b May 29, 2019
kmcfaul added 2 commits May 30, 2019
@dlabaj
dlabaj approved these changes Jun 5, 2019
@redallen redallen merged commit 60b4d91 into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.