Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(background image): Convert background image to typescript #2070

Merged
merged 9 commits into from Jun 5, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 23, 2019

Fixes #2069

Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #2070 into master will increase coverage by 0.02%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2070      +/-   ##
==========================================
+ Coverage   81.09%   81.12%   +0.02%     
==========================================
  Files         643      644       +1     
  Lines        7706     7723      +17     
  Branches      451      458       +7     
==========================================
+ Hits         6249     6265      +16     
  Misses       1257     1257              
- Partials      200      201       +1
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.97% <95.23%> (+0.07%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...react-core/src/components/BackgroundImage/index.ts 100% <100%> (ø)
...src/components/BackgroundImage/BackgroundImage.tsx 96.42% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c04803...947564c. Read the comment docs.

Copy link
Contributor

redallen left a comment

Looks great, thanks!

Jessie added 2 commits May 23, 2019
Jessie
Jessie
Copy link
Contributor

redallen left a comment

Typescript, yay! 👍

Copy link
Contributor

dlabaj left a comment

A few comments

});

it('Verify filter has correct class', () => {
cy.get('svg').should('have.class', 'pf-c-background-image__filter')

This comment has been minimized.

Copy link
@dlabaj

dlabaj May 28, 2019

Contributor

Should we have a test if there's no svg filter?

This comment has been minimized.

Copy link
@jessiehuff

jessiehuff May 29, 2019

Author Contributor

I made the svg filter optional for this, but I'm not sure what kind of test to run for that in the demo since I can only load one background image. Thoughts?

Jessie added 2 commits May 29, 2019
Jessie
Jessie
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jun 4, 2019

Fixes #2100

@dlabaj
dlabaj approved these changes Jun 5, 2019
@dlabaj dlabaj merged commit d4ae6db into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.