Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use frontmatter for what props to show in docs #2072

Merged
merged 8 commits into from May 29, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented May 23, 2019

What: Fixes #2003

Additional issues:

redallen added 2 commits May 23, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #2072 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files         636      636           
  Lines        7560     7560           
  Branches      451      451           
=======================================
  Hits         6148     6148           
  Misses       1212     1212           
  Partials      200      200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.2% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288da47...dcf78e1. Read the comment docs.

redallen and others added 5 commits May 23, 2019
Jessie
Jessie
Jessie
fix
@redallen redallen requested a review from jschuler May 24, 2019
Copy link
Contributor

dlabaj left a comment

LGTM

@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented May 28, 2019

@redallen Popover.md has a conflict.

@redallen redallen dismissed stale reviews from dlabaj and dgutride via dcf78e1 May 29, 2019
@dlabaj
dlabaj approved these changes May 29, 2019
@dgutride dgutride merged commit 20e6b12 into patternfly:master May 29, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redallen redallen deleted the redallen:docs/frontmatter-props branch May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.