Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-styles): move react styles #2085

Merged
merged 28 commits into from Jun 5, 2019
Merged

Conversation

@redallen
Copy link
Contributor

redallen commented May 24, 2019

What: Change all the React css imports and add types for them. Instead of using a babel plugin to generate the JS at compile time for our CSS-in-JS solution, we statically generate it beforehand in react-styles.

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #2085 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
+ Coverage   80.31%   80.83%   +0.52%     
==========================================
  Files         651      651              
  Lines        8300     8260      -40     
  Branches      628      628              
==========================================
+ Hits         6666     6677      +11     
+ Misses       1333     1282      -51     
  Partials      301      301
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.45% <100%> (+0.97%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/scripts/snapshot-serializer.js 100% <ø> (ø)
...4/react-core/src/components/Select/SingleSelect.js 81.25% <ø> (ø) ⬆️
...rc/components/Table/utils/decorators/classNames.js 75% <ø> (ø) ⬆️
...atternfly-4/react-core/src/components/Tabs/Tabs.js 80.76% <ø> (ø) ⬆️
...react-core/src/components/DataList/DataListCell.js 100% <ø> (ø) ⬆️
...-4/react-core/src/components/Dropdown/Separator.js 100% <ø> (ø) ⬆️
...act-core/src/components/Dropdown/DropdownToggle.js 85.71% <ø> (ø) ⬆️
...rnfly-4/react-core/src/components/Select/Select.js 58% <ø> (ø) ⬆️
...ponents/ApplicationLauncher/ApplicationLauncher.js 50% <ø> (ø) ⬆️
...ct-core/src/components/ClipboardCopy/CopyButton.js 100% <ø> (ø) ⬆️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4d91...6531d73. Read the comment docs.

@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented May 28, 2019

@redallen Looks like there's a conflict with .babelrc

redallen added 5 commits May 28, 2019
@redallen redallen force-pushed the dgutride:move-styles branch from 256c778 to 4283e8d Jun 5, 2019
@redallen redallen force-pushed the dgutride:move-styles branch from 4283e8d to dfbd98f Jun 5, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 5, 2019

@dlabaj
dlabaj approved these changes Jun 5, 2019
@dlabaj dlabaj merged commit 81d1ed2 into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.