Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Add defaults for component props #2103

Merged
merged 1 commit into from May 30, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented May 29, 2019

This simply allows users to override props like labelComponent, containerComponent, etc.

Fixes #2102

@dlabrecq dlabrecq force-pushed the dlabrecq:2102-chart-defaults branch from 03183e2 to c0d1d32 May 29, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 29, 2019

Copy link
Contributor

redallen left a comment

Just be explicit about the templated types and fix the one linter error and this is good!

/home/travis/build/patternfly/patternfly-react/packages/patternfly-4/react-charts/src/components/ChartLegend/ChartLegend.js
  86:7  error  Replace `(⏎··<VictoryLegend⏎····containerComponent={containerComponent}⏎····dataComponent={dataComponent}⏎····theme={theme}⏎····{...rest}⏎··/>⏎)` with `<VictoryLegend·containerComponent={containerComponent}·dataComponent={dataComponent}·theme={theme}·{...rest}·/>`  prettier/prettier
@dlabrecq dlabrecq force-pushed the dlabrecq:2102-chart-defaults branch from c0d1d32 to 90e07ff May 29, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2103 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         643      643           
  Lines        7706     7706           
  Branches      451      451           
=======================================
  Hits         6249     6249           
  Misses       1257     1257           
  Partials      200      200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.89% <66.66%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nts/ChartVoronoiContainer/ChartVoronoiContainer.js 80% <0%> (ø) ⬆️
...4/react-charts/src/components/ChartPie/ChartPie.js 100% <100%> (ø) ⬆️
...t-charts/src/components/ChartLegend/ChartLegend.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f968287...8663886. Read the comment docs.

This will allow devs to override props like labelComponent, containerComponent, etc.

#2102
@dlabrecq dlabrecq force-pushed the dlabrecq:2102-chart-defaults branch from 90e07ff to 8663886 May 30, 2019
@tlabaj
tlabaj approved these changes May 30, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes May 30, 2019
@dlabaj dlabaj merged commit ca98322 into patternfly:master May 30, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dlabrecq dlabrecq deleted the dlabrecq:2102-chart-defaults branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.