Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backdrop): Convert backdrop to typescript #2105

Merged
merged 3 commits into from Jun 10, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 29, 2019

Fixes #2104

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2105 into master will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
- Coverage   80.84%   80.82%   -0.03%     
==========================================
  Files         651      652       +1     
  Lines        8260     8260              
  Branches      628      630       +2     
==========================================
- Hits         6678     6676       -2     
  Misses       1282     1282              
- Partials      300      302       +2
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.42% <81.81%> (-0.05%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...4/react-core/src/components/Modal/ModalContent.tsx 67.74% <100%> (ø) ⬆️
.../src/components/AboutModal/AboutModalContainer.tsx 92.3% <100%> (ø) ⬆️
...nfly-4/react-core/src/components/Backdrop/index.ts 100% <100%> (ø)
...-4/react-core/src/components/Backdrop/Backdrop.tsx 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3da9a...323f5cb. Read the comment docs.

Jessie
Jessie
@tlabaj
tlabaj approved these changes Jun 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit fd3d771 into patternfly:master Jun 10, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.