Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): update SelectProps interface, clean up demos #2107

Merged
merged 1 commit into from May 29, 2019

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented May 29, 2019

What: This PR updates the SelectProps interface to avoid a type error when importing react-core into a TypeScript application. I also removed some unnecessary code in a couple of the demo's I followed recently. Copying the code as is was creating an error. I think they were safe deletions but worth double checking.

Additional issues: #2106

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         643      643           
  Lines        7706     7706           
  Branches      451      451           
=======================================
  Hits         6249     6249           
  Misses       1257     1257           
  Partials      200      200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.89% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c04803...4c2166b. Read the comment docs.

@jschuler jschuler merged commit b56ea35 into patternfly:master May 29, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tlabaj tlabaj mentioned this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.