Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Charts): Fix themes for bar chart default colors #2112

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented May 29, 2019

Fixes #2111

What:
Add default bar fill color to all themes so that standard (ungrouped) bar charts will have an appropriate fill color.

@TheRealJon TheRealJon requested a review from dlabrecq May 29, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 29, 2019

@TheRealJon TheRealJon force-pushed the TheRealJon:issue-2111 branch 2 times, most recently from bf7c24e to cae43c4 May 30, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #2112 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2112   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         648      648           
  Lines        7869     7869           
  Branches      505      505           
=======================================
  Hits         6370     6370           
  Misses       1259     1259           
  Partials      240      240
Flag Coverage Δ
#patternfly3 85.21% <ø> (ø) ⬆️
#patternfly4 76.28% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ts/src/components/ChartTheme/themes/theme-color.js 100% <ø> (ø) ⬆️
...nents/ChartTheme/themes/light/theme-color-multi.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c81d2f...4701224. Read the comment docs.

@TheRealJon TheRealJon requested a review from dlabrecq May 30, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented May 30, 2019

I have no idea why snapshots are failing. I've done everything I know to do to make sure the snapshots are up to date, and they should be, but for some reason, unit tests are still failing. @dlabrecq Any ideas?

@dlabrecq

This comment has been minimized.

Copy link
Member

dlabrecq commented May 30, 2019

I recall encountering a similar error with stale packages, but running yarn install; yarn test -u seemed to clear it up.

@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented May 31, 2019

Tried that. Tried a clean yarn install at the root level, clean build of all packages, and full unit test run with -u flag, got no new snapshot updates.

@TheRealJon TheRealJon dismissed stale reviews from tlabaj and dlabrecq via 4701224 May 31, 2019
@TheRealJon TheRealJon force-pushed the TheRealJon:issue-2111 branch from cae43c4 to 4701224 May 31, 2019
@TheRealJon TheRealJon requested review from dlabrecq and tlabaj and removed request for dlabrecq May 31, 2019
@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented May 31, 2019

@dlabrecq @tlabaj Could I get approvals again? I had to push updated test snapshots to get CI to pass.

@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented Jun 3, 2019

@tlabaj Could you approve again? Looks like CI is passing now. Should be good to merge.

@tlabaj
tlabaj approved these changes Jun 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 7b290ab into patternfly:master Jun 3, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TheRealJon TheRealJon deleted the TheRealJon:issue-2111 branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.