Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): make PopoverPosition an enum #2113

Merged
merged 2 commits into from May 30, 2019

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented May 29, 2019

What: This PR changes PopoverPosition from a const to an enum. This allows users to specify their choice of a string or object property for the position property value on Popover component. Also adds a test that exercises this method to ensure it doesn't regress going forward.

Additional issues: #2099

@seanforyou23 seanforyou23 added the PF4 label May 29, 2019
@seanforyou23 seanforyou23 requested review from jschuler, dgutride and redallen May 29, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2113 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2113      +/-   ##
=========================================
+ Coverage   81.09%   81.1%   +<.01%     
=========================================
  Files         643     643              
  Lines        7706    7710       +4     
  Branches      451     451              
=========================================
+ Hits         6249    6253       +4     
  Misses       1257    1257              
  Partials      200     200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.92% <100%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Popover/Popover.tsx 62.96% <100%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f968287...22ca46c. Read the comment docs.

@jeff-phillips-18

This comment has been minimized.

Copy link
Member

jeff-phillips-18 commented May 30, 2019

One small comment, If you could re-title the PR to make it clear that this is fixing the const (code) not the actual visual position of popovers. I expected something different when I read the title.

Copy link
Contributor

redallen left a comment

Thanks!

@redallen redallen changed the title fix(popover): fix PopoverPosition fix(popover): make PopoverPosition an enum May 30, 2019
@redallen redallen merged commit 4afe336 into patternfly:master May 30, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redallen redallen mentioned this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.