Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PF4 Table): Export RowWrapper implementation #2118

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented May 30, 2019

What:
When using react table in typescript project there is no way how to import RowWrapper implementation and copy pasting parts of it is bad. So this PR fixes this problem by exporting RowWrapperProps as interface and RowWrapper as implementation.

Additional issues:
There might be problems because we are changing interface to implementation, but this is not that greatly used interface so it should be fine. @suomiy, @priley86 are you using this interface somewhere?

Fixes: #2109

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #2118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2118   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files         642      642           
  Lines        7781     7781           
  Branches      504      504           
=======================================
  Hits         6283     6283           
  Misses       1258     1258           
  Partials      240      240
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.28% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87724c6...b9785b5. Read the comment docs.

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented May 30, 2019

Fixes #2109

Copy link
Member

priley86 left a comment

I am no longer using Row/Body/Cell Wrappers. No issues w/ this.

@redallen redallen merged commit 557b4a9 into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.