Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): Allow custom header and footer #2120

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented May 30, 2019

What:
Allows for custom header and/or footer in Modal component

Fixes #1545

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:modal-header branch from d77464c to 40b7f63 May 31, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 31, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@cdac10a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2120   +/-   ##
=========================================
  Coverage          ?   80.75%           
=========================================
  Files             ?      642           
  Lines             ?     7791           
  Branches          ?      509           
=========================================
  Hits              ?     6292           
  Misses            ?     1259           
  Partials          ?      240
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 76.31% <100%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...-core/src/components/Modal/ModalBoxCloseButton.tsx 75% <ø> (ø)
...ernfly-4/react-core/src/components/Modal/Modal.tsx 88.23% <ø> (ø)
...4/react-core/src/components/Modal/ModalContent.tsx 72.97% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdac10a...e511d47. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 requested review from redallen and tlabaj May 31, 2019
@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:modal-header branch from 40b7f63 to 767a659 May 31, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 31, 2019

@jeff-phillips-18 jeff-phillips-18 changed the title feat(Modal): Allow custom header and footer WIP: feat(Modal): Allow custom header and footer Jun 3, 2019
Copy link
Contributor

redallen left a comment

Fix conflicts and this is good!

@Hyperkid123

This comment has been minimized.

Copy link
Contributor

Hyperkid123 commented Jul 26, 2019

@jeff-phillips-18 can you fix the conflicts please? We could really use this one. Or if you want I cant take this over.

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:modal-header branch from 767a659 to 39902cc Jul 29, 2019
@jeff-phillips-18 jeff-phillips-18 changed the title WIP: feat(Modal): Allow custom header and footer feat(Modal): Allow custom header and footer Jul 29, 2019
@jeff-phillips-18

This comment has been minimized.

Copy link
Member Author

jeff-phillips-18 commented Jul 29, 2019

Rebased, removed WIP

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 29, 2019

PatternFly-React preview: https://patternfly-react-pr-2120.surge.sh

@Hyperkid123

This comment has been minimized.

Copy link
Contributor

Hyperkid123 commented Jul 30, 2019

@jeff-phillips-18 is it possible to include the close button to the modal Header? That would let us to customize the header completely.

Right now the button is the only thing that we cannot do anything about.

@jeff-phillips-18

This comment has been minimized.

Copy link
Member Author

jeff-phillips-18 commented Jul 30, 2019

@Hyperkid123 Added the showClose prop, defaulted to true. Set to false to hide the close button.

Copy link
Contributor

redallen left a comment

LGTM

@tlabaj
tlabaj approved these changes Jul 30, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Jul 30, 2019
@dlabaj dlabaj merged commit 9d2f157 into patternfly:master Jul 30, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 30, 2019

Your changes have been released in:

  • @patternfly/react-core@3.79.0
  • @patternfly/react-docs@4.9.10
  • @patternfly/react-inline-edit-extension@2.9.56
  • demo-app-ts@2.14.0
  • @patternfly/react-integration@2.14.0
  • @patternfly/react-table@2.15.4
  • @patternfly/react-topology@2.7.5
  • @patternfly/react-virtualized-extension@1.1.89

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.