Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NavItem): Maintain className passed to custom NavItems #2134

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Jun 3, 2019

What:
Keeps classNames set on the child of a custom NavItem.

Fixes #2133

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #2134 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
+ Coverage   80.96%   80.97%   +0.01%     
==========================================
  Files         649      649              
  Lines        7885     7885              
  Branches      505      505              
==========================================
+ Hits         6384     6385       +1     
  Misses       1261     1261              
+ Partials      240      239       -1
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.3% <0%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Nav/NavItem.tsx 57.14% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495082...371520e. Read the comment docs.

Copy link
Contributor

redallen left a comment

Awesome, thanks!

Copy link
Member

rebeccaalpert left a comment

Looks great to me.

@tlabaj
tlabaj approved these changes Jun 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 8f38b97 into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.