Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aboutmodal): support isOpen initially set true in about modal #2153

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@priley86
Copy link
Member

priley86 commented Jun 4, 2019

What:
Noticed this while release testing @patternfly/react-core 3.34.0 today. This will just ensure the about modal container exists on initial load if isOpen is passed true with children contents initially...

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 4, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #2153 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2153      +/-   ##
=========================================
+ Coverage   80.49%   80.5%   +<.01%     
=========================================
  Files         649     649              
  Lines        8225    8229       +4     
  Branches      610     611       +1     
=========================================
+ Hits         6621    6625       +4     
  Misses       1308    1308              
  Partials      296     296
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 75.77% <66.66%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/AboutModal/AboutModal.tsx 77.77% <66.66%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7c0f...d38f7d5. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #2153 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2153      +/-   ##
=========================================
+ Coverage   80.49%   80.5%   +<.01%     
=========================================
  Files         649     649              
  Lines        8225    8229       +4     
  Branches      610     611       +1     
=========================================
+ Hits         6621    6625       +4     
  Misses       1308    1308              
  Partials      296     296
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 75.77% <66.66%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/AboutModal/AboutModal.tsx 77.77% <66.66%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7c0f...d38f7d5. Read the comment docs.

@tlabaj
tlabaj approved these changes Jun 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Jun 5, 2019
@dlabaj dlabaj merged commit d8209ad into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.