Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): chart: wrong 'children' type #2155

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jun 4, 2019

Modifies Chart & ChartStack to use ReactNode as children type.

Fixes #2152

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 4, 2019

@tlabaj
tlabaj approved these changes Jun 4, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 0b0a828 into patternfly:master Jun 4, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dlabrecq dlabrecq deleted the dlabrecq:2152-chart-children branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.