Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tabs ref proptype #2158

Merged
merged 2 commits into from Jun 5, 2019
Merged

fix tabs ref proptype #2158

merged 2 commits into from Jun 5, 2019

Conversation

@jschuler
Copy link
Collaborator

jschuler commented Jun 4, 2019

Closes: #2151 #2132

jschuler added 2 commits Jun 4, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #2158 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
+ Coverage   80.49%   80.51%   +0.01%     
==========================================
  Files         649      649              
  Lines        8225     8225              
  Branches      610      610              
==========================================
+ Hits         6621     6622       +1     
+ Misses       1308     1307       -1     
  Partials      296      296
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 75.77% <100%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...fly-4/react-core/src/components/Tabs/TabContent.js 83.33% <ø> (ø) ⬆️
...patternfly-4/react-core/src/components/Tabs/Tab.js 100% <100%> (ø) ⬆️
...atternfly-4/react-core/src/components/Tabs/Tabs.js 80.76% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbc01f...98e6d22. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 4, 2019

@dlabaj
dlabaj approved these changes Jun 4, 2019
@tlabaj
tlabaj approved these changes Jun 4, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@jschuler

This comment has been minimized.

Copy link
Collaborator Author

jschuler commented Jun 4, 2019

Closing i think there is still an issue left. will reopen when ready

@jschuler jschuler closed this Jun 4, 2019
@jschuler jschuler reopened this Jun 5, 2019
@jschuler

This comment has been minimized.

Copy link
Collaborator Author

jschuler commented Jun 5, 2019

It's good to merge as is

@dlabaj dlabaj merged commit e28c44d into patternfly:master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.