Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Topology): Add @patternfly/react-topology package #2170

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Jun 5, 2019

What:
Add initial @patternfly/react-topology package containing the TopologyView and TopologyControlBar components.

FYI: @christianvogt

@jeff-phillips-18 jeff-phillips-18 requested review from dgutride and redallen Jun 5, 2019
@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch 2 times, most recently from 076e232 to 363d793 Jun 6, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #2170 into master will increase coverage by 0.09%.
The diff coverage is 55.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
+ Coverage   80.44%   80.53%   +0.09%     
==========================================
  Files         662      656       -6     
  Lines        8349     8364      +15     
  Branches      643      687      +44     
==========================================
+ Hits         6716     6736      +20     
+ Misses       1331     1282      -49     
- Partials      302      346      +44
Flag Coverage Δ
#patternfly3 85.22% <ø> (-0.02%) ⬇️
#patternfly4 75.97% <55.76%> (+0.2%) ⬆️
#patternflymisc 95.68% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
...c/components/TopologyView/css/topology-view-css.ts 100% <100%> (ø)
...eact-topology/src/components/TopologyView/index.ts 100% <100%> (ø)
.../TopologyControlBar/css/topology-controlbar-css.ts 100% <100%> (ø)
...mponents/TopologyControlBar/TopologyControlBar.tsx 46.42% <46.42%> (ø)
...ology/src/components/TopologyView/TopologyView.tsx 93.33% <93.33%> (ø)
...ternfly-4/react-table/src/components/Table/Body.js 87.5% <0%> (-0.74%) ⬇️
test.env.js 100% <0%> (ø) ⬆️
...ct-core/src/components/Pagination/OptionsToggle.js 83.33% <0%> (ø) ⬆️
...y-3/patternfly-react/src/components/Label/Label.js 100% <0%> (ø) ⬆️
...ly-3/patternfly-react/src/components/Cards/Card.js 100% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8bf5f5...7f1ca55. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch from 14f7491 to e5cba76 Jun 6, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 6, 2019

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch 2 times, most recently from 58a8a12 to c6589e6 Jun 6, 2019
Copy link
Contributor

redallen left a comment

I love this package, thanks!

@@ -0,0 +1,8 @@
const fs = require('fs');

This comment has been minimized.

Copy link
@redallen

redallen Jun 7, 2019

Contributor

Don't need this file since jest uses the one from react-core.

@@ -0,0 +1,15 @@
const path = require('path');

This comment has been minimized.

Copy link
@redallen

redallen Jun 7, 2019

Contributor

With no .d.ts files in this project, we don't need this script.

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch from c6589e6 to c7341fd Jun 10, 2019
@jeff-phillips-18

This comment has been minimized.

Copy link
Member Author

jeff-phillips-18 commented Jun 10, 2019

Updated per comments, rebased.

Copy link
Member

dgutride left a comment

I think it looks pretty good - one or two minor build adjustments on my end

@@ -96,6 +96,7 @@ exports.onCreateWebpackConfig = ({ actions }) => {
'@patternfly/react-styles': path.resolve(__dirname, '../react-styles'),
'@patternfly/react-table': path.resolve(__dirname, '../react-table'),
'@patternfly/react-tokens': path.resolve(__dirname, '../react-tokens'),
'@patternfly/react-topology': path.resolve(__dirname, '../react-topology/dist/esm'),

This comment has been minimized.

Copy link
@dgutride

dgutride Jun 11, 2019

Member

Why does this need the module path specifically?

This comment has been minimized.

Copy link
@jeff-phillips-18

jeff-phillips-18 Jun 11, 2019

Author Member

I was having a strange build issue w/o the path. That seems to be resolved now so I believe I can remove it.

"build:babel:cjs": "cross-env BABEL_ENV=production:cjs babel src --out-dir dist/js --extensions '.js,.ts,.tsx' -q",
"build:babel:esm": "cross-env BABEL_ENV=production:esm babel src --out-dir dist/esm --extensions '.js,.ts,.tsx' -q",
"build:babel:umd": "cross-env BABEL_ENV=production:umd babel dist/esm --out-dir dist/umd --plugins transform-es2015-modules-umd --extensions '.js,.ts,.tsx' -q",
"build:babel:cjs": "babel src --out-dir dist/js --extensions '.js,.ts,.tsx' -q",

This comment has been minimized.

Copy link
@dgutride

dgutride Jun 11, 2019

Member

This file shouldn't be included here - please revert

@@ -0,0 +1,5 @@
const coreConfig = require('../react-core/.babelrc.js');

This comment has been minimized.

Copy link
@dgutride

dgutride Jun 11, 2019

Member

This location changed to the root of patternfly-4 now

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch 3 times, most recently from 572f15e to a39dd88 Jun 11, 2019
@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:topology-package branch from a39dd88 to 7f1ca55 Jun 11, 2019
Copy link
Contributor

redallen left a comment

Thanks again!

@redallen redallen merged commit 58eb9cc into patternfly:master Jun 11, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.