Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PF4: Pagination): When empty array sent to pagination no per page should be visible #2175

Merged
merged 1 commit into from Jun 7, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Jun 6, 2019

What:
Per page option should be possible to hide by passing empty array of per page options.

Additional issues:
Fixes: #2174

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 6, 2019

@karelhala karelhala force-pushed the karelhala:no-per-page branch from 887e971 to 31d40a8 Jun 7, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 7, 2019

Codecov Report

Merging #2175 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2175   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files         649      649           
  Lines        8204     8204           
  Branches      628      628           
=======================================
  Hits         6622     6622           
  Misses       1282     1282           
  Partials      300      300
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.15% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...src/components/Pagination/PaginationOptionsMenu.js 92.3% <ø> (ø) ⬆️
...ct-core/src/components/Pagination/OptionsToggle.js 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6afc1...1419b17. Read the comment docs.

…e should be visible
@karelhala karelhala force-pushed the karelhala:no-per-page branch from 31d40a8 to 1419b17 Jun 7, 2019
@tlabaj
tlabaj approved these changes Jun 7, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit cb97dfd into patternfly:master Jun 7, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.