Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(esm): fix esm output and convert react-virtualized-extension to TS #2190

Merged
merged 6 commits into from Jun 10, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jun 7, 2019

What: Fix recent regression from #2085 that made our dist only commons JS for a few packages. Clean babelrc.js and babel build targets to be consistent across packages. Fix jest config afterwards.

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@979f13f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2190   +/-   ##
=========================================
  Coverage          ?   85.49%           
=========================================
  Files             ?      370           
  Lines             ?     4040           
  Branches          ?        0           
=========================================
  Hits              ?     3454           
  Misses            ?      586           
  Partials          ?        0
Flag Coverage Δ
#patternfly3 85.23% <100%> (?)
#patternflymisc 95.79% <100%> (?)
Impacted Files Coverage Δ
...ents/Cards/UtilizationTrendCard/UtilizationCard.js 100% <ø> (ø)
...ly-3/patternfly-react/src/components/Cards/Card.js 100% <ø> (ø)
test.env.js 100% <100%> (ø)
...y-3/patternfly-react/src/components/Cards/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979f13f...10f007a. Read the comment docs.

@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Jun 10, 2019

thanks @redallen ! will try to test this out this week.

redallen added 3 commits Jun 10, 2019
@priley86 priley86 merged commit b35f3d1 into patternfly:master Jun 10, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.