Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-table): Some props of IRow should not required #2196

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@kunyan
Copy link
Contributor

kunyan commented Jun 10, 2019

What:

Makes following props of IRow to optional

  • isOpen
  • parent
  • props

rows.every(row => this.isSelected(row) || (row.hasOwnProperty('parent') && !row.showSelect));

The parent props should not define anything to pass the check

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 10, 2019

@redallen redallen merged commit 343f928 into patternfly:master Jun 10, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.