Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): Add support for .pf-m-grid-2xl breakpoint #2206

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jun 10, 2019

Added breakpoint to list of available breakpoints and updated snapshot.

Fixes #2198.

Added breakpoint to list of available breakpoints and updated snapshot.

Fixes #2198
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 10, 2019

@rebeccaalpert rebeccaalpert requested a review from mcoker Jun 10, 2019
@tlabaj
tlabaj approved these changes Jun 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@mcoker
mcoker approved these changes Jun 10, 2019
Copy link
Contributor

mcoker left a comment

great!

@dlabaj
dlabaj approved these changes Jun 10, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #2206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2206   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files         662      662           
  Lines        8349     8349           
  Branches      643      643           
=======================================
  Hits         6716     6716           
  Misses       1331     1331           
  Partials      302      302
Flag Coverage Δ
#patternfly3 85.23% <ø> (ø) ⬆️
#patternfly4 75.77% <ø> (ø) ⬆️
#patternflymisc 95.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-table/src/components/Table/Table.js 86.36% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3d771...41ddbc7. Read the comment docs.

@rebeccaalpert rebeccaalpert merged commit 0f9ebf9 into patternfly:master Jun 10, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:table-breakpoint branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.