Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputGroup): Convert input group to typescript #2220

Merged
merged 10 commits into from Jun 27, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jun 11, 2019

Fixes #2219

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 11, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 12, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a5d571e). Click here to learn what that means.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2220   +/-   ##
=========================================
  Coverage          ?   79.89%           
=========================================
  Files             ?      670           
  Lines             ?     8547           
  Branches          ?      738           
=========================================
  Hits              ?     6829           
  Misses            ?     1363           
  Partials          ?      355
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 74.95% <85%> (?)
#patternflymisc 95.79% <ø> (?)
Impacted Files Coverage Δ
.../react-core/src/components/TextInput/TextInput.tsx 96.29% <0%> (ø)
...ly-4/react-core/src/components/InputGroup/index.ts 100% <100%> (ø)
...eact-core/src/components/InputGroup/InputGroup.tsx 100% <100%> (ø)
...-core/src/components/InputGroup/InputGroupText.tsx 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d571e...464a17b. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 12, 2019

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/inputGroupTS branch from 1054177 to 28e3c09 Jun 18, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 18, 2019

PatternFly-React preview: https://patternfly-react-pr-2220.surge.sh

Jessie
Jessie
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 27, 2019

PatternFly-React preview: https://patternfly-react-pr-2220.surge.sh

@tlabaj
tlabaj approved these changes Jun 27, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@redallen redallen merged commit 0313519 into patternfly:master Jun 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.