Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): Pagination Component Typescript Conversion #2256

Merged
merged 12 commits into from Jul 2, 2019

Conversation

@nicolethoen
Copy link
Contributor

nicolethoen commented Jun 13, 2019

Addresses issue 2115

Includes new demo and cypress tests

@nicolethoen nicolethoen requested review from jschuler, dlabaj and redallen Jun 13, 2019
@nicolethoen nicolethoen changed the title Pagination ts conversion feat(Pagination): Pagination Component Typescript Conversion Jun 13, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 13, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 13, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2107ebf). Click here to learn what that means.
The diff coverage is 75.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2256   +/-   ##
=========================================
  Coverage          ?   79.79%           
=========================================
  Files             ?      670           
  Lines             ?     8608           
  Branches          ?      790           
=========================================
  Hits              ?     6869           
  Misses            ?     1357           
  Partials          ?      382
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 74.83% <75.89%> (?)
#patternflymisc 95.79% <ø> (?)
Impacted Files Coverage Δ
...y-4/react-core/src/components/Pagination/index.tsx 100% <100%> (ø)
...ckages/patternfly-4/react-core/src/helpers/util.ts 58.1% <100%> (ø)
...-core/src/components/Pagination/ToggleTemplate.tsx 42.85% <42.85%> (ø)
...t-core/src/components/Pagination/OptionsToggle.tsx 50% <50%> (ø)
...eact-core/src/components/Pagination/Navigation.tsx 73.17% <58.82%> (ø)
...eact-core/src/components/Pagination/Pagination.tsx 91.11% <86.66%> (ø)
...rc/components/Pagination/PaginationOptionsMenu.tsx 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2107ebf...df8cadd. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 14, 2019

@nicolethoen nicolethoen force-pushed the nicolethoen:pagination_ts_conversion branch 2 times, most recently from 1e6d39c to 2caea93 Jun 17, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 18, 2019

PatternFly-React preview: https://patternfly-react-pr-2256.surge.sh

@nicolethoen

This comment has been minimized.

Copy link
Contributor Author

nicolethoen commented Jun 25, 2019

@tlabaj @dlabaj can I get a review from a senior dev on this?

@nicolethoen nicolethoen dismissed stale reviews from rebeccaalpert and redallen via 601a7d9 Jun 25, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor Author

nicolethoen commented Jun 25, 2019

@tlabaj @dlabaj nvm I did something wrong when I rebased. I'll ping you again when I have it sorted out

@nicolethoen nicolethoen force-pushed the nicolethoen:pagination_ts_conversion branch from 601a7d9 to 3abc4c3 Jun 25, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor Author

nicolethoen commented Jun 25, 2019

@dlabaj @tlabaj okay, sorry for the blast of notifications, but I think it's ready for review now. my rebasing did lose @rebeccaalpert and @redallen's approvals

Copy link
Contributor

redallen left a comment

Just one change left, thanks!

@nicolethoen nicolethoen force-pushed the nicolethoen:pagination_ts_conversion branch from 4fe1a51 to dd616a8 Jul 1, 2019
@dlabrecq

This comment has been minimized.

Copy link
Member

dlabrecq commented Jul 1, 2019

I attempted to test this with Cost Management, but the Tippy issue is getting in the way. If you can rebase after the release is fixed, I'll test again.

@nicolethoen nicolethoen force-pushed the nicolethoen:pagination_ts_conversion branch from dd616a8 to df8cadd Jul 1, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor Author

nicolethoen commented Jul 1, 2019

@dlabrecq done

Copy link
Member

dlabrecq left a comment

LGTM.

I built and installed the changes with Cost Management. I don't see any compile errors or issues in the browser console.

Copy link
Contributor

redallen left a comment

Glad you managed to get some bugfixes in here too!

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jul 2, 2019

Will merge after the latest prerelease gets promoted.

Copy link
Contributor

jessiehuff left a comment

LGTM! :)

@tlabaj
tlabaj approved these changes Jul 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 8a29a20 into patternfly:master Jul 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.