Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-core): add ouia compatibility to Switch #2304

Merged
merged 4 commits into from Jul 8, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jun 19, 2019

What: Fixes #2303 for a Switch by conditionally adding data-ouia-component-type and data-ouia-component-id for Switch based on window.localStorage['ouia']. Do not merge until some further discussion takes place on #2303 .

Edit: Discussion has taken place, we can merge now.

Additional issues:

@redallen redallen changed the title feat(react-core): add ouia compatibility to Switch POC: feat(react-core): add ouia compatibility to Switch Jun 19, 2019
@redallen redallen self-assigned this Jun 19, 2019
@redallen redallen force-pushed the redallen:poc-ouia branch from 49fc98e to 5f3680a Jun 19, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2304.surge.sh

@quarckster

This comment has been minimized.

Copy link
Contributor

quarckster commented Jun 20, 2019

thanks @redallen I couldn't test changes of this PR in https://patternfly-react-pr-2304.surge.sh/. I set a localStorage variable window.localStorage.setItem("ouia", true), refreshed the page but nothing changed in the DOM. I couldn't find data-ouia attributes. On the other hand, it works if you build PR locally, it was tested by @karelhala

@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jun 20, 2019

@quarckster Gatsby statically renders the site without window defined, so after you set the localStorage variable you have to interact with the switch to cause it to re-render, then you'll see the tags. Sorry, that's a caveat I forgot to mention.

@redallen redallen removed the Do Not Merge label Jun 24, 2019
@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jun 24, 2019

After discussion with the OUIA team, this PR is good to merge and have many more followups for all our components that would want integration testing.

@tlabaj tlabaj requested review from dlabaj and jschuler Jun 25, 2019
@dlabaj dlabaj removed their assignment Jun 27, 2019
@dgutride dgutride changed the title POC: feat(react-core): add ouia compatibility to Switch feat(react-core): add ouia compatibility to Switch Jun 28, 2019
@dgutride dgutride self-assigned this Jun 28, 2019
@redallen redallen dismissed stale reviews from karelhala and dgutride via f759923 Jul 3, 2019
@redallen redallen force-pushed the redallen:poc-ouia branch from 5685730 to f759923 Jul 3, 2019
@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jul 3, 2019

@dgutride @karelhala Fixed merge conflicts, please re-approve!

@jschuler jschuler merged commit 2cc4d48 into patternfly:master Jul 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 8, 2019

Your changes have been released in:

  • @patternfly/react-core@3.63.0
  • @patternfly/react-docs@4.8.61
  • @patternfly/react-inline-edit-extension@2.9.24
  • demo-app-ts@2.5.2
  • @patternfly/react-table@2.13.55
  • @patternfly/react-topology@2.5.5
  • @patternfly/react-virtualized-extension@1.1.57

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.