Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesfeat(react-core): add ouia compatibility to Switch #2304
Conversation
This comment has been minimized.
This comment has been minimized.
PatternFly-React preview: https://patternfly-react-pr-2304.surge.sh |
This comment has been minimized.
This comment has been minimized.
thanks @redallen I couldn't test changes of this PR in https://patternfly-react-pr-2304.surge.sh/. I set a localStorage variable |
This comment has been minimized.
This comment has been minimized.
@quarckster Gatsby statically renders the site without |
This comment has been minimized.
This comment has been minimized.
After discussion with the OUIA team, this PR is good to merge and have many more followups for all our components that would want integration testing. |
This comment has been minimized.
This comment has been minimized.
@dgutride @karelhala Fixed merge conflicts, please re-approve! |
packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Your changes have been released in:
Thanks for your contribution! |
redallen commentedJun 19, 2019
•
edited
What: Fixes #2303 for a Switch by conditionally adding
data-ouia-component-type
anddata-ouia-component-id
for Switch based onwindow.localStorage['ouia']
.Do not merge until some further discussion takes place on #2303 .Edit: Discussion has taken place, we can merge now.
Additional issues: