Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Progress): Convert progress to TypeScript #2307

Merged
merged 2 commits into from Jun 27, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jun 19, 2019

Converted progress to TypeScript.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2307.surge.sh

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:progress-typescript branch from 732f75a to 6e5f208 Jun 19, 2019
@tlabaj tlabaj added the chore 🏠 label Jun 20, 2019
Copy link
Contributor

redallen left a comment

I agree with Joachim's comments.

@rebeccaalpert rebeccaalpert dismissed stale reviews from kmcfaul and boaz0 via ff4d26f Jun 25, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:progress-typescript branch 2 times, most recently from b26925d to dd2c81a Jun 25, 2019
Copy link
Contributor

redallen left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

LGTM

@rebeccaalpert rebeccaalpert dismissed stale reviews from tlabaj and redallen via 5ddf8f3 Jun 27, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:progress-typescript branch from dd2c81a to 5ddf8f3 Jun 27, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj
tlabaj approved these changes Jun 27, 2019
@jschuler jschuler merged commit dd47390 into patternfly:master Jun 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.