Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expandable): Add button type to the Expandable Component #2340

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@debsmita1
Copy link
Contributor

debsmita1 commented Jun 24, 2019

What: Added button type to the component, without which it acts like a submit button on a form.

Additional issues: None

Fixes: #2339

Added type button without which the component acts like a submit button on a form
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 24, 2019

PatternFly-React preview: https://patternfly-react-pr-2340.surge.sh

Copy link
Contributor

dlabaj left a comment

Looks like you need to update your snapshots for the JEST tests.

@tlabaj
tlabaj approved these changes Jun 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Jun 25, 2019
@dlabaj dlabaj merged commit 670b8a1 into patternfly:master Jun 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.