Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(Notification Badge): Adds the notification badge component #2342
mcarrano left a comment
@dlabaj Visually this looks good, but I do have a question about behavior. This is intended to work as a toogle for opening and closing the notification drawer. So when the drawer is open it would display a selected state until the user clicks it again to close the drawer. It's hard to tell from the preview of the icon only, but it looks like this is coded to behave link a standard action button.
Here is the latest visual spec: https://marvelapp.com/project/4090736/
@mcarrano Right now this is an external component that can also be used outside of the notification drawer. Is the circle around it when it's toggled on suppose to be shown when it's not used with the notification drawer?
@christiemolloy @mcoker I don't see the toggled on circle in the core example. https://pf4.patternfly.org/components/NotificationBadge/examples/ Is this being added in a modifier that we will get later?
This looks great @dlabaj and we hadn't addressed the circle background behind the icon yet because we still need to discuss how to best implement it in Core. I'm going to create a separate issue for it because patternfly/patternfly-next#1832 is large and addresses different concepts. Issue here: patternfly/patternfly-next#1998 ... @rachael-phillips making you aware.