Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): Make variant prop optional #2348

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jun 25, 2019

Made variant prop optional.

Fixes #2345.

Fixes #2345
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2348.surge.sh

@tlabaj tlabaj requested a review from jessiehuff Jun 25, 2019
@tlabaj
tlabaj approved these changes Jun 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Jun 25, 2019
@dlabaj dlabaj merged commit b17fa06 into patternfly:master Jun 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.