Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): update text in form component #2352

Merged
merged 2 commits into from Jun 25, 2019
Merged

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jun 25, 2019

Fixes #2347

Jessie
@jessiehuff jessiehuff requested a review from tlabaj Jun 25, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2352.surge.sh

@tlabaj tlabaj self-assigned this Jun 25, 2019
@tlabaj tlabaj requested review from redallen and christiemolloy Jun 25, 2019
@christiemolloy

This comment has been minimized.

Copy link
Member

christiemolloy commented Jun 25, 2019

Screen Shot 2019-06-25 at 3 05 33 PM

can you also remove the required from these too? @jessiehuff

Jessie
Copy link
Member

christiemolloy left a comment

LGTM

@tlabaj
tlabaj approved these changes Jun 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@boaz0
boaz0 approved these changes Jun 25, 2019
Copy link
Member

boaz0 left a comment

Good job!

@redallen redallen merged commit 929ed2d into patternfly:master Jun 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.