Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): Automatically focus first dropdown item when DropdownMenu mounts #2355

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented Jun 25, 2019

fix #2083

What:
Update DropdownMenu to focus first dropdown item on mount so that keyboard navigation will always work.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2355.surge.sh

Copy link
Contributor

karelhala left a comment

Looking good!

@dlabaj
dlabaj approved these changes Jun 27, 2019
@dlabaj dlabaj merged commit 276f5fb into patternfly:master Jun 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@TheRealJon TheRealJon deleted the TheRealJon:issue-2083 branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.