Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add POC for experimental button and badge #2363

Merged
merged 3 commits into from Jul 22, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jun 26, 2019

What: Add dist/esm/expiremental, which is not exported from the main index.js. Add support for the docs to show them. Towards patternfly/patternfly-org#1247 .

Additional issues: Fixes #2300

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 26, 2019

PatternFly-React preview: https://patternfly-react-pr-2363.surge.sh

Copy link
Member

jeff-phillips-18 left a comment

Can you explain the point behind the Experimental components? What are is the purpose behind these?

Object.values([true, false]).forEach(isRead => {
test(`${isRead} Badge`, () => {
const view = shallow(<Badge isRead={isRead}>{isRead ? 'read' : 'unread'} Badge</Badge>);
expect(view).toMatchSnapshot();

This comment has been minimized.

Copy link
@jeff-phillips-18

jeff-phillips-18 Jul 1, 2019

Member

I'd really like to see test that check for expected values rather than relying on snapshots. That is, adding a check for the existance of the pf-m-unread when isRead is false and for pf-m-read when isRead is true.

This comment has been minimized.

Copy link
@redallen

redallen Jul 1, 2019

Author Contributor

These components will likely be removed, they are just to test the site for now. I agree the tests should cover the experimental features.

@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jul 1, 2019

The relevant issue I added the the OP, it's patternfly/patternfly-org#1247 . We'd like for these components to be available as a separate export and be subject to frequent breaking changes or removal.

@redallen redallen force-pushed the redallen:feat/experimental branch from b15b044 to 1720b3a Jul 2, 2019
@redallen redallen changed the title feat(expiremental): add POC for expiremental button and badge feat(experimental): add POC for experimental button and badge Jul 2, 2019
@redallen redallen force-pushed the redallen:feat/experimental branch from 1720b3a to de2d02f Jul 2, 2019
@redallen redallen removed the Do Not Merge label Jul 15, 2019
Copy link
Contributor

karelhala left a comment

Looking good! Thanks for this package, it will be much easier for us to try these experimental things.

@redallen redallen force-pushed the redallen:feat/experimental branch from de2d02f to 725929b Jul 19, 2019
@dgutride dgutride merged commit 3d4d322 into patternfly:master Jul 22, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 22, 2019

Your changes have been released in:

  • @patternfly/react-core@3.75.0
  • @patternfly/react-docs@4.9.0
  • @patternfly/react-inline-edit-extension@2.9.47
  • demo-app-ts@2.12.9
  • @patternfly/react-table@2.14.21
  • @patternfly/react-topology@2.6.18
  • @patternfly/react-virtualized-extension@1.1.80

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.