Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): Add compact card variation #2399

Merged
merged 9 commits into from Jul 1, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Jun 28, 2019

Fixes #2392

Jessie
@jessiehuff jessiehuff requested a review from christiemolloy Jun 28, 2019
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 28, 2019

PatternFly-React preview: https://patternfly-react-pr-2399.surge.sh

@christiemolloy

This comment has been minimized.

Copy link
Member

christiemolloy commented Jun 28, 2019

Looks great @jessiehuff one thing though the headers in the card are set to pf-m-lg when they should be pf-m-md. 16px vs 18px.

Screen Shot 2019-06-28 at 12 26 56 PM

Screen Shot 2019-06-28 at 12 27 04 PM

@jessiehuff jessiehuff assigned jessiehuff and unassigned jessiehuff Jun 28, 2019
Jessie added 2 commits Jun 28, 2019
Jessie
Jessie
Copy link
Member

christiemolloy left a comment

LGTM

Jessie
@jessiehuff jessiehuff dismissed stale reviews from redallen and christiemolloy via 94ea900 Jun 28, 2019
Jessie
Copy link
Contributor

tlabaj left a comment

Can you update the cypress test as well.

Jessie
Jessie
@jessiehuff jessiehuff dismissed stale reviews from redallen and jschuler via bedea17 Jun 28, 2019
@jschuler jschuler dismissed tlabaj’s stale review Jul 1, 2019

Comment was addressed

@jschuler jschuler merged commit e27ad9e into patternfly:master Jul 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.