Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OptionsMenu): Add disabled modifier to the toggle #2401

Merged
merged 4 commits into from Jul 1, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Jun 28, 2019

#2396

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 28, 2019

PatternFly-React preview: https://patternfly-react-pr-2401.surge.sh

Titani
@tlabaj tlabaj requested a review from christiemolloy Jun 28, 2019
Titani
@christiemolloy

This comment has been minimized.

Copy link
Member

christiemolloy commented Jul 1, 2019

@tlabaj when I click on the non-disabled plain dropdown, the disabled dropdown inherits the active color

Screen Shot 2019-07-01 at 8 59 53 AM

Copy link
Contributor

redallen left a comment

Looks good on JS side.

const toggle = <OptionsMenuToggle onToggle={this.onToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>
const toggle = <OptionsMenuToggle onToggle={this.onDisabledToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>
const disabledToggle = <OptionsMenuToggle isDisabled onToggle={this.onToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>

This comment has been minimized.

Copy link
@jschuler

jschuler Jul 1, 2019

Collaborator

the onToggle here should be this.onDisabledToggle and the previous one should be this.onToggle?

This comment has been minimized.

Copy link
@jschuler

jschuler Jul 1, 2019

Collaborator

This will also address @christiemolloy 's comment

Titani
Copy link
Member

christiemolloy left a comment

thanks for updating

@jschuler jschuler merged commit c6693c1 into patternfly:master Jul 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.