Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): tab container refs #2402

Merged
merged 2 commits into from Jul 1, 2019
Merged

Conversation

@redallen
Copy link
Contributor

redallen commented Jun 28, 2019

What: Fix typescript errors and revert TabContainer to a component. Resolves #2359

Additional issues:

Copy link
Member

dlabrecq left a comment

Can you please also fix the type of innerRef to match forwardRef? I tested this with the Cost Management UI.

Screen Shot 2019-06-28 at 3 42 11 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 28, 2019

PatternFly-React preview: https://patternfly-react-pr-2402.surge.sh

@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jun 28, 2019

Good catch @dlabrecq . Pushed.

@redallen redallen changed the title fix(tabs): refs fix(tabs): tab container refs Jul 1, 2019
@jschuler jschuler merged commit 3c0a8a1 into patternfly:master Jul 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.