Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): always remove size props from {...props} #2404

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jun 28, 2019

What: Resolves #2403

Additional issues:

@redallen redallen changed the title fix(grid): always remove props from {...props} fix(grid): always remove size props from {...props} Jun 28, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 28, 2019

PatternFly-React preview: https://patternfly-react-pr-2404.surge.sh

Copy link
Contributor

jessiehuff left a comment

LGTM, glad you caught this!

@dlabaj dlabaj added the PF4 label Jul 1, 2019
Copy link
Contributor

dlabaj left a comment

@redallen Can we get an issue created for this and linked to this PR. Thanks

@dlabaj dlabaj added the bug 🐛 label Jul 1, 2019
@dlabrecq

This comment has been minimized.

Copy link
Member

dlabrecq commented Jul 1, 2019

The issue would be #2403

@redallen redallen merged commit f549b95 into patternfly:master Jul 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.