Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): Let users enter numbers into the input field #2417

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jul 1, 2019

Users can now enter numbers into the input field without highlighting the page number in the input field. You have to hit enter in order for the change to go through and affect the dropdown/buttons. Non-integer inputs will default to the previous page number on enter.

Fixes #2344.

@rebeccaalpert rebeccaalpert added the PF4 label Jul 1, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 1, 2019

PatternFly-React preview: https://patternfly-react-pr-2417.surge.sh

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:pagination-input branch from 6d87751 to 7799001 Jul 1, 2019
Copy link
Contributor

redallen left a comment

This is awesome, thanks so much!

@tlabaj tlabaj added the bug 🐛 label Jul 5, 2019
@tlabaj tlabaj requested a review from jschuler Jul 5, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:pagination-input branch 2 times, most recently from f114549 to fe4baf1 Jul 9, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented Jul 9, 2019

Refactored to work with Nicole's TypeScript conversion.

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:pagination-input branch from fe4baf1 to c891b8b Jul 10, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:pagination-input branch from c891b8b to 67b74ae Jul 10, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented Jul 10, 2019

Addressed PR feedback.

Copy link
Contributor

redallen left a comment

LGTM! 🥇

Copy link
Contributor

jessiehuff left a comment

LGTM :)

@tlabaj
tlabaj approved these changes Jul 11, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 38ed9d8 into patternfly:master Jul 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 11, 2019

Your changes have been released in:

  • @patternfly/react-core@3.70.0
  • @patternfly/react-docs@4.8.73
  • @patternfly/react-inline-edit-extension@2.9.36
  • demo-app-ts@2.11.0
  • @patternfly/react-integration@2.11.0
  • @patternfly/react-table@2.14.10
  • @patternfly/react-topology@2.6.7
  • @patternfly/react-virtualized-extension@1.1.69

Thanks for your contribution! 🎉

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 5, 2019
this changed here patternfly/patternfly-react#2417
(previous behavior was instant execution on any input)
AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Aug 5, 2019
…#389)

this changed here patternfly/patternfly-react#2417
(previous behavior was instant execution on any input)
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
… (#389)

this changed here patternfly/patternfly-react#2417
(previous behavior was instant execution on any input)
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
… (#389)

this changed here patternfly/patternfly-react#2417
(previous behavior was instant execution on any input)
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
… (#389)

this changed here patternfly/patternfly-react#2417
(previous behavior was instant execution on any input)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.