Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add optional display via children to option #2419

Merged
merged 5 commits into from Jul 12, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 1, 2019

What: Allows custom display of options via the children param.

Additional issues: #2370

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 1, 2019

PatternFly-React preview: https://patternfly-react-pr-2419.surge.sh

Copy link
Contributor

tlabaj left a comment

I would also update the demo and integration test for this change.

@kmcfaul

This comment has been minimized.

Copy link
Contributor Author

kmcfaul commented Jul 8, 2019

@tlabaj I had added some unit tests for the custom display, as I wasn't sure if we wanted to show the custom display in our demos. Which demo should I edit to use the children prop, or should I add another separate demo for it?

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Jul 8, 2019

@kmcfaul I was talking about adding a demo to our integration app and adding cypress test.

@tlabaj tlabaj self-assigned this Jul 8, 2019
kmcfaul added 2 commits Jul 11, 2019
…f selected item

when custom select option is used, the custom display should be shown on the selected item instead
of value
@kmcfaul

This comment has been minimized.

Copy link
Contributor Author

kmcfaul commented Jul 11, 2019

Added logic so the custom option is displayed instead of value when selected, up in the toggle, if it is present.
Added logic so typeahead uses display text for default filtering. Custom filtering will be added in another PR.

Two examples have been added to the TypeScript demo - single and multi typeahead.

…ahead, update TS demo, fix cypr
@tlabaj
tlabaj approved these changes Jul 12, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@redallen redallen merged commit 03be1a7 into patternfly:master Jul 12, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 12, 2019

Your changes have been released in:

  • @patternfly/react-core@3.71.0
  • @patternfly/react-docs@4.8.75
  • @patternfly/react-inline-edit-extension@2.9.38
  • demo-app-ts@2.12.0
  • @patternfly/react-integration@2.12.0
  • @patternfly/react-table@2.14.12
  • @patternfly/react-topology@2.6.9
  • @patternfly/react-virtualized-extension@1.1.71

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.