Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add definition list use case #2422

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Jul 2, 2019

What:

closes #2390

Added the html structure of Accordion to React.

//cc @jgiardino @christiemolloy

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 2, 2019

PatternFly-React preview: https://patternfly-react-pr-2422.surge.sh

@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from e1f7c54 to 9043810 Jul 2, 2019
Copy link
Contributor

tlabaj left a comment

The issue says the default should be a <dl>. The way it is coded here, the default would be a< div>

@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from 9043810 to e06bab3 Jul 8, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch 3 times, most recently from b5ea6ef to e4adbb8 Jul 21, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 21, 2019

PatternFly-React preview: https://patternfly-react-pr-2422.surge.sh

@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from e4adbb8 to 654170d Jul 22, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 22, 2019

PatternFly-React preview: https://patternfly-react-pr-2422.surge.sh

Copy link
Contributor

jessiehuff left a comment

LGTM :)

@redallen redallen dismissed tlabaj’s stale review Jul 22, 2019

Default is now

@boaz0 boaz0 dismissed stale reviews from jessiehuff, redallen, and kmcfaul via 6fd77b8 Jul 23, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from 654170d to 6fd77b8 Jul 23, 2019
Copy link
Contributor

redallen left a comment

Still looking good!

Copy link
Contributor

tlabaj left a comment

LGTM


export interface AccordionContentProps extends React.HTMLProps<HTMLElement> {
export interface AccordionContentProps extends React.HTMLProps<HTMLDivElement> {

This comment has been minimized.

Copy link
@jschuler

jschuler Jul 25, 2019

Collaborator

Looks like this could be HTMLDivElement or the equivalent for dd. Not sure how this could be typed/handled. Any ideas? @redallen @seanforyou23

@boaz0 boaz0 dismissed stale reviews from tlabaj, kmcfaul, and redallen via 9b46347 Jul 25, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from 6fd77b8 to 9b46347 Jul 25, 2019
Copy link
Contributor

mcoker left a comment

👍 lgtm, thanks @boaz0!!

Copy link
Contributor

tlabaj left a comment

LGTM

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 dismissed stale reviews from tlabaj, redallen, and mcoker via 1a88a26 Jul 29, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2390 branch from 9b46347 to 1a88a26 Jul 29, 2019
@tlabaj
tlabaj approved these changes Jul 30, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@jschuler

This comment has been minimized.

Copy link
Collaborator

jschuler commented Jul 30, 2019

Thanks @boaz0 !

@jschuler jschuler merged commit 7211713 into patternfly:master Jul 30, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 30, 2019

Your changes have been released in:

  • @patternfly/react-core@3.80.0
  • @patternfly/react-docs@4.9.11
  • @patternfly/react-inline-edit-extension@2.9.57
  • demo-app-ts@2.14.1
  • @patternfly/react-table@2.15.5
  • @patternfly/react-topology@2.7.6
  • @patternfly/react-virtualized-extension@1.1.90

Thanks for your contribution! 🎉

@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Jul 30, 2019

Yeay!
Thank you all @tlabaj @redallen @jessiehuff @kmcfaul @mcoker @jschuler for your review especially @jschuler

@boaz0 boaz0 deleted the boaz0:closes_2390 branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.