Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(aboutModal+modal): now trap focus in browser #2428
What: AboutModal and Modal both now trap focus in the browser. However, screenreader accessibility is currently functioning only in modal, which was fixed @boaz0 's PR referenced below -- I added his change to this PR.
More feedback is necessary as to how to go about making screenreader accessibility work with AboutModal. Any assistance here would be appreciated.
Hey @jenny-s51 - these updates are great!
I tested keyboard accessibility using the following steps, and it worked as expected
There is an issue in the DOM that would affect screen reader accessibility. The following screencap shows
Your changes have been released in:
Thanks for your contribution!