Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chart): Fix runtime errors related to theme padding #2430

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented Jul 2, 2019

Add more robust logic for setting padding values in Chart component

fix #2429

What:

  • Add new util function for getting padding values from props and falling back to the theme
  • Use new util function in Chart component to get default padding values
Add more robust logic for setting padding values in Chart component

fix #2429
@TheRealJon TheRealJon requested a review from dlabrecq Jul 2, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 2, 2019

PatternFly-React preview: https://patternfly-react-pr-2430.surge.sh

@TheRealJon TheRealJon requested a review from dgutride Jul 2, 2019
@tlabaj
tlabaj approved these changes Jul 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit a4d9f75 into patternfly:master Jul 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@TheRealJon TheRealJon deleted the TheRealJon:issue-2429 branch Jul 2, 2019
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jul 2, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.4.7

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.