Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pr-comments): add PR comment on publish #2433

Merged
merged 2 commits into from Jul 5, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Jul 2, 2019

What: Add comments on publishing a prerelease that lists the published versions. Example PR comment: #2433 (comment)

Additional issues: Also gently refactor upload-docs.sh to be parametrized.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 2, 2019

PatternFly-React preview: https://patternfly-react-pr-2433.surge.sh

@redallen redallen force-pushed the redallen:feat/pr-version-comments branch from 52af960 to 13278bc Jul 2, 2019
@redallen redallen requested review from dgutride, jschuler and dlabaj Jul 2, 2019
@dgutride

This comment has been minimized.

Copy link
Member

dgutride commented Jul 3, 2019

@redallen - does this update a PR that has been merged or add the possible next versions for a PR that is still open?

@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Jul 3, 2019

@dgutride This adds a comment to a PR after it has been merged and successfully published.

@jschuler jschuler merged commit eead819 into patternfly:master Jul 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.