Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add select custom filter callback #2434

Merged
merged 5 commits into from Jul 29, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 2, 2019

What: Adds a custom callback for the filtering function used in typeahead variants. This replaces the current search entirely, so the function must handle filtering the list of children/options and return the filtered results for the internal state to update.

Additional issues: #2369

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 2, 2019

PatternFly-React preview: https://patternfly-react-pr-2434.surge.sh

@tlabaj tlabaj requested review from jschuler and dlabaj Jul 3, 2019
@kmcfaul kmcfaul force-pushed the kmcfaul:select-custom-filter branch from 4ef3717 to 6e3c6b0 Jul 12, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

LGTM

@jschuler

This comment has been minimized.

Copy link
Collaborator

jschuler commented Jul 24, 2019

LGTM, but noticed two other things:

  1. When i type something and filter down the results, and then close and reopen the dropdown (the filter text is still applied) it shows me the whole list again. Is this expected?
  2. When i start typing and the dropdown is closed, it does not automatically open. I would expect it to open
@kmcfaul

This comment has been minimized.

Copy link
Contributor Author

kmcfaul commented Jul 26, 2019

  1. When you close the menu the filter resets. If you select an item, that is filled into the input but it isn't acting as a filter, and maybe that should change?

  2. is being addressed in a separate PR

@kmcfaul kmcfaul force-pushed the kmcfaul:select-custom-filter branch from 3e39d49 to fee95bd Jul 26, 2019
@tlabaj
tlabaj approved these changes Jul 29, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 878a107 into patternfly:master Jul 29, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 29, 2019

Your changes have been released in:

  • @patternfly/react-core@3.78.0
  • @patternfly/react-docs@4.9.9
  • @patternfly/react-inline-edit-extension@2.9.55
  • demo-app-ts@2.13.3
  • @patternfly/react-table@2.15.3
  • @patternfly/react-topology@2.7.4
  • @patternfly/react-virtualized-extension@1.1.88

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.