Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart theme to use pf-core variables #2439

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 3, 2019

This updates the chart theme to use pf-core vars -- the majority of changes are to base-theme.ts.

Also adds some padding to chart examples to address #2438.

fixes #2280
fixes #2438

A couple minor pf-core tweaks will need to be added in a later PR.
patternfly/patternfly-next#2011

@dlabrecq dlabrecq force-pushed the dlabrecq:2280-core-vars branch 2 times, most recently from c6eb4d4 to 203eb33 Jul 3, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:2280-core-vars branch from 203eb33 to b849d0f Jul 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2439.surge.sh

Copy link
Contributor

jcaianirh left a comment

lgtm

@tlabaj
tlabaj approved these changes Jul 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 7fdb144 into patternfly:master Jul 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@dlabrecq dlabrecq deleted the dlabrecq:2280-core-vars branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.