Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add bottom-left legend position #2442

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jul 3, 2019

Cost Management needs to align legends on the bottom-left, for its area charts. This change adds support for a bottom-left aligned legend.

Screen Shot 2019-07-03 at 9 35 50 AM

fixes #2441

@dlabrecq dlabrecq force-pushed the dlabrecq:2441-legend-left branch from 5027383 to 53c1594 Jul 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-2442.surge.sh

@tlabaj tlabaj requested a review from TheRealJon Jul 5, 2019
Copy link
Contributor

redallen left a comment

Fix merge conflicts and this is good 👍

@dlabrecq dlabrecq force-pushed the dlabrecq:2441-legend-left branch from 53c1594 to c798f29 Jul 9, 2019
@dlabrecq dlabrecq removed the request for review from TheRealJon Jul 10, 2019
@redallen redallen changed the title Charft: Add bottom-left legend position Chart: Add bottom-left legend position Jul 10, 2019
@tlabaj
tlabaj approved these changes Jul 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 1f52911 into patternfly:master Jul 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 10, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.5.0

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:2441-legend-left branch Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.